search

aerospike-community / aerospike-client-php

Aerospike client for PHP7
Apache License 2.0
29 stars 28 forks source link

Duplicated constant in aerospike doc file #27

Closed MortalFlesh closed 5 years ago

MortalFlesh commented 5 years ago

Hello,

As I mentioned in https://github.com/aerospike/aerospike-client-php/pull/26 I've found some fatal errors in docs, which I guess is used to autocomplete in the IDE.

I've added missing semicolons, but there is still one fatal error - duplicated constant OPT_SOCKET_TIMEOUT - I would gladly fix it but I don't know, which one is correct..

There is one on https://github.com/aerospike/aerospike-client-php/blob/master/doc/phpdoc/aerospike.php#L3365 and the second one on https://github.com/aerospike/aerospike-client-php/blob/master/doc/phpdoc/aerospike.php#L3600

aerospikerobertmarks commented 5 years ago

Hi @MortalFlesh , excellent find.

The definition on: https://github.com/aerospike/aerospike-client-php/blob/master/doc/phpdoc/aerospike.php#L3600

is the correct version.

aerospikerobertmarks commented 5 years ago

Resolved in 7.3.0. Thanks again for the fix.