Fix ulong to zend_ulong in conversations.c

aerospike-community / aerospike-client-php

Aerospike client for PHP7

Apache License 2.0

29 stars 28 forks source link

Fix ulong to zend_ulong in conversations.c #51

Closed compositephp closed 4 years ago

compositephp commented 4 years ago

Extension failed to compile with error: /vendor/aerospike/aerospike-client-php/src/conversions.c:457:7: error: expected ';' after expression ulong numeric_key; ^ ; vendor/aerospike/aerospike-client-php/src/conversions.c:457:2: error: use of undeclared identifier 'ulong' ulong numeric_key;

dwelch-spike commented 4 years ago

Hi @compositephp,

Thank you for the contribution! Would you mind telling me what platform and PHP version you experienced this failure on?

Thanks.

compositephp commented 4 years ago

Hi @dwelch-spike, MacOS Catalina 10.15.3 php -v PHP 7.4.2 (cli) (built: Jan 22 2020 06:30:58) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.2, Copyright (c), by Zend Technologies

dwelch-spike commented 4 years ago

@compositephp Thank you for the information and thanks again for the contribution!

As a note, the php client does not officially support php7.4 yet but it should be able to compile. This and any other fixes/testing required for php7.4 support will go out in a future release.