search

aerospike / aerospike-client-c

Aerospike C Client
Other
98 stars 103 forks source link

Fixing thread safety issue on shutdown #117

Closed ghost closed 2 years ago

ghost commented 2 years ago

Found with thread sanitizer so I'm not 100% sure this will hit in the real world. The idea is the write for the bool cluster->valid is not guarded. The check here is guarded https://github.com/aerospike/aerospike-client-c/blob/master/src/main/aerospike/as_shm_cluster.c#L802 but the bool is not guarded on destory.

BrianNichols commented 2 years ago

Your pull request has been accepted into our stage branch. It will be included in the next C client release.

BrianNichols commented 2 years ago

C client 5.2.8 is released: https://download.aerospike.com/download/client/c/notes.html#5.2.8