search

aerospike / aerospike-client-csharp

Aerospike C# Client Library
70 stars 48 forks source link

Allowing inner Exception to be null in AerospikeException constructor #102

Closed m-wilmo closed 9 months ago

m-wilmo commented 9 months ago

Several AerospikeException.Timeout constructors take an optional inner exception, by default null.

However they use this AerospikeException constructor for their base classes, which can't deal with a null Exception argument.

Right now, using these AerospikeException.Timeout constructors without specifying an Inner Exception will result in an "Object reference not set to an instance of an object" error if no inner exception is given.

This happens at several places at least within Aerospike.Client.AsyncCommand.cs.

m-wilmo commented 9 months ago

Hello @shannonklaus, how are you ?

Could I ask for a review on this ?

Thank you for your time !

shannonklaus commented 9 months ago

Thank you for your pull request. This change will be included in the next release, which I expect will be in a few weeks or so.