search

aerospike / aerospike-client-go

Aerospike Client Go
Apache License 2.0
430 stars 198 forks source link

Export estimateSize method for different Datastructures #298

Closed sainadh-d closed 4 years ago

sainadh-d commented 4 years ago

The estimateSize method on different Data structures like MapValue, ListValue etc is unexported in the go client, where as the same is Public in Java Client.

Is there any reason for keeping this unexported ? It would be useful thing to get approximate estimates of record sizes.

khaf commented 4 years ago

No specific reason, I can expose them later. Although keep in mind that these are expensive methods for lists and maps.

sainadh-d commented 4 years ago

@khaf Thanks for the response. I did the changes in my fork a while back for testing something. Raised a PR. Pls check https://github.com/aerospike/aerospike-client-go/pull/299 True that these are expensive. I was just using it for estimation purposes and not in the critical paths of the application.

khaf commented 4 years ago

Resolved in v2.11.0.