connection_heap remainder issue

aerospike / aerospike-client-go

Aerospike Client Go

Apache License 2.0

430 stars 198 forks source link

connection_heap remainder issue #332

Closed xqzhang2015 closed 3 years ago

xqzhang2015 commented 3 years ago

Should it be this?

if maxSize-(perHeapSize*heapCount) > 0 {
}

https://github.com/aerospike/aerospike-client-go/blob/163beaf5fce2a90b8a7690b5c41aa58347b9f224/connection_heap.go#L195

xqzhang2015 commented 3 years ago

@khaf Would you like to give any comment?

khaf commented 3 years ago

You are right. Seems like at some point I have changed the logic, but haven't changed the calcs everywhere. Will fix on today's release. Thanks for reporting the issue.

khaf commented 3 years ago

This was fixed in v4.1.0. I had missed putting the notice in the Changelog. Thanks for the report, and the Changelog will be updated in the next release.