search

aerospike / aerospike-client-go

Aerospike Client Go
Apache License 2.0
430 stars 199 forks source link

regenerated auth and kv protobuf go files and deleted outdated ones #425

Closed conradsmi closed 3 months ago

conradsmi commented 4 months ago

Regenerated files via protoc --proto_path=auth auth/*.proto --go_out=auth --go_opt=paths=source_relative and protoc --proto_path=kvs kvs/*.proto --go_out=kvs --go_opt=paths=source_relative for proto/aerospike_proxy_auth.proto and proto/aerospike_proxy_kv.proto, respectively.

This should resolve #414, as proto/aerospike_proxy_auth_grpc.pb.go and proto/aerospike_proxy_kv_grpc.pb.go were regenerated as a part of a previous fix, but the non-grpc ones were seemingly skipped over.

If this is approved and merged, another PR should apply the fix to v6 as well.

khaf commented 3 months ago

@conradsmi Thanks for the steps to repro your results. Due to security concerns, I did not merge your PR (it's really hard to verify generated code), but I used your steps to generate the code again on my end. The issue should be resolved now in the v7.2.0 release. I'll close this ticket, but feel free to reopen it in case the issue is not mitigated.