search

aerospike / aerospike-client-java

Aerospike Java Client Library
Other
236 stars 212 forks source link

Possibility to add circle ci integration #111

Closed Aloren closed 6 years ago

Aloren commented 6 years ago

Is it possible to enable circleci integration for this project? It will run automatic builds for each opened pull request -- no broken code will be merged into master.

The only prerequisite for this change is: setting up aerospike-server in tests via testcontainers. I could implement this change via pr if you like the idea.

BrianNichols commented 6 years ago

Sure, we would accept a pull request for this.

BrianNichols commented 6 years ago

It has been pointed out to me that our other projects use travis (like our C client) for CI. We would prefer a pull request using travis if possible.

Aloren commented 6 years ago

Ok, I will prepare pull request with embedded aerospike firstly. Thanks

bsideup commented 6 years ago

@Aloren @BrianNichols just fyi: Testcontainers works perfectly fine on Travis :) As simple as adding these two lines to the config:

sudo: required
services:
  - docker
BrianNichols commented 6 years ago

We decided to go with our traditional approach used in our other client repositories.