Closed Aloren closed 6 years ago
Sure, we would accept a pull request for this.
It has been pointed out to me that our other projects use travis (like our C client) for CI. We would prefer a pull request using travis if possible.
Ok, I will prepare pull request with embedded aerospike firstly. Thanks
@Aloren @BrianNichols just fyi: Testcontainers works perfectly fine on Travis :) As simple as adding these two lines to the config:
sudo: required
services:
- docker
We decided to go with our traditional approach used in our other client repositories.
Is it possible to enable circleci integration for this project? It will run automatic builds for each opened pull request -- no broken code will be merged into master.
The only prerequisite for this change is: setting up aerospike-server in tests via testcontainers. I could implement this change via pr if you like the idea.