search

aerospike / aerospike-client-java

Aerospike Java Client Library
Other
236 stars 212 forks source link

Prepare module with aerospike-container #113

Closed Aloren closed 6 years ago

Aloren commented 6 years ago

Aerospike container with minimal changes

Aloren commented 6 years ago

@BrianNichols testcontainers library depends on jdk 1.8. It means that it also can not be included into parent due to 1.7 jdk that is used to compile project. This issue can be resolved just by updating jdk version to 1.8 on agent that makes project. Source and target for maven-compiler-plugin already have correct versions for all modules. Aerospike-client will still be compatible and run on jdk 1.7, but we will also be able to compile all build in one run.

If you do not like this idea there is another option. Modules that require 1.7 jdk can be built using 1.7 jdk, other still will use jdk 1.8: Compile using different jdk

BrianNichols commented 6 years ago

This pull request is a different approach than our travis implementation for the C client. The C client uses a ".travis.yml" which uses bash like commands to download/install the server and run client tests. We are evaluating whether this different approach has real value over our existing approach.

I do think it makes sense to implement some sort of travis CI. We will eventually let you know our decision.

sahlone commented 6 years ago

Can we not leverage docker for the setup and the Travis can be configured to run the tests on docker

BrianNichols commented 6 years ago

We decided to go with our traditional approach used in our other client repositories.