aerospike / aerospike-client-python

Aerospike Python Client
Apache License 2.0
134 stars 111 forks source link

[CLIENT-3106] Fix reference count error caused by not properly incrementing reference count for Py_None object #672

Closed juliannguyen4 closed 2 months ago

juliannguyen4 commented 2 months ago

None's reference count needs to be managed properly for Python 3.11 and lower

https://docs.python.org/3.11/c-api/none.html#c.Py_None https://docs.python.org/3.12/c-api/none.html#c.Py_None

Massif memory usage seems ok: https://github.com/aerospike/aerospike-client-python/actions/runs/10887384965/job/30209613022 No memory errors from valgrind: https://github.com/aerospike/aerospike-client-python/actions/runs/10887382672

Build wheels macOS x86 tests fail fast even though I disabled that. Have to investigate later, but besides that, it should be fine

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.96%. Comparing base (d1e7bc2) to head (63260df). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #672 +/- ## ======================================= Coverage 80.96% 80.96% ======================================= Files 100 100 Lines 15130 15132 +2 ======================================= + Hits 12250 12252 +2 Misses 2880 2880 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.