search

aerospike / aerospike-client-rust

Rust client for the Aerospike database
https://www.aerospike.com/
Other
82 stars 29 forks source link

Fixed large integers packing when encoding to messagepack #116

Closed bmuddha closed 1 year ago

bmuddha commented 2 years ago

Closes #115

khaf commented 2 years ago

Thanks for your PR. Could you please include a test case to make sure the issue doesn't creep back into the code base in the future?

bmuddha commented 2 years ago

Thanks for your PR. Could you please include a test case to make sure the issue doesn't creep back into the code base in the future?

Done, added new test case for query with filter on large i64 value

khaf commented 2 years ago

Could you please revert the write confirmation removal? Writes are not fire and forget and the server may return meaningful errors.

bmuddha commented 2 years ago

Oops, I'm really sorry, it slipped through when I was experimenting on my own project, reverted it back

khaf commented 1 year ago

Thanks for your pull request. Sorry it took us a while to release it.