search

aerospike / aerospike-client-rust

Rust client for the Aerospike database
https://www.aerospike.com/
Other
82 stars 26 forks source link

Fix warnings and errors #61

Closed dnaka91 closed 4 years ago

dnaka91 commented 4 years ago

When working on my previous PR I got lots of deprecation and other warnings. So I went ahead and fixed all of them. Although the changes are simple, they are many so I split the work up into separate commits to simplify the review.

After fixing all the main warnings I ran clippy and the story continued. In the end I enabled more clippy lints and also ran clippy with nightly which gave even more warnings.

The disabled clippy lints are made either because the required changes to fix them would be rather big or the suggestions are incompatible with Rust 1.34.0.

Unfortunately the clippy of 1.34.0 doesn't work as some dependencies use configurations of newer versions.

jhecking commented 4 years ago

Great! Thanks a lot. I'm traveling at the moment so still probably only get around to review this next week.

dnaka91 commented 4 years ago

Thanks for checking this huge PR. Maybe, now that this is merged, you can release a new version?

jhecking commented 4 years ago

Maybe, now that this is merged, you can release a new version?

I'll try to release a new version by the end of the week.

jhecking commented 4 years ago

I'll try to release a new version by the end of the week.

Was about to release v0.4.0, but then noticed that the benchmark tool (./tools/benchmark) doesn't compile any more using Rust 1.34 or 1.39. Want to get that fixed first, so haven't released the package yet.

dnaka91 commented 4 years ago

Ah the benchmark tool, that already didn't compile before my changes so I didn't bother.

Didn't look into what the benchmark tool does exactly, but maybe some parts can be replaced by https://crates.io/crates/criterion?

jhecking commented 4 years ago

criterion might be useful for the benchmark in ./benches/client_server.rs. The benchmark tool in ./tools/benchmark simulates real client requests and measures throughput and latency.

Sent with GitHawk

jhecking commented 4 years ago

I've just published v0.4.0 to crates.io.