search

aerostitch / testnavit

0 stars 0 forks source link

Ramp name and ref are not announced #205

Open aerostitch opened 11 years ago

aerostitch commented 11 years ago

Issue migrated from trac ticket # 1174

component: core | priority: minor | keywords: routing, directions, ramp, highways

2013-10-04 09:01:12: arnaud.lemeur@gmail.com created the issue

When the navigation requests to turn to an exit, the indication does not include exit name nor ref. It is only considered as a classical "turn right".

I suggest to modify the announce as "turn right into the ramp $name $ref".

It seems that the announcement of ramp is already implemented but it is only working on ramps without name nor ref.

Navit version : Android svn5643

aerostitch commented 11 years ago

2013-10-04 12:20:51: usul

aerostitch commented 11 years ago

2013-10-04 12:20:51: usul commented

Thanks for the report!

It would be very good for testing, if you could provide us with a demo-route, plz?

Sadly I'm not into the code and cant say, if this is easy or hard to realize (depends if this informations are available to the routing/directions-engine). Usually I would expect that it can be done quickly, but call me wrong!

As this is not essential feature (stability/real safety), I will schedule it just for 0.6 major release, as there is currently already much todo for the 0.5.1 minor.

aerostitch commented 11 years ago

2013-10-18 23:42:24: arnaud.lemeur@gmail.com changed severity from * to normal*

aerostitch commented 11 years ago

2013-10-18 23:42:24: arnaud.lemeur@gmail.com commented

Replying to [#1174 arnaud le meur]:

When the navigation requests to turn to an exit, the indication does not include exit name nor ref. It is only considered as a classical "turn right".

In fact I was disturbed by the fact that the last announcement does not include ref and name, but I confirm that turn into a ramp is announced as a classical "turn right/left" if the next segment includes ref or name and "turn right/left into the ramp" if not.

Another point is that many ramps don't include ref and name but the info is available on the connection point tagged as "motorway_junction". Does navit handle junctions to navigate ?

aerostitch commented 10 years ago

2014-09-22 06:03:20: @mvglasow commented

I've thought about this as well. I would suggest to add a new attribute to each item in the route. which gets populated in the following manner:

  • name or ref of the way immediately following the maneuver
  • failing that, one of the following:
    • if the way following the maneuver is a ramp and has no name or ref, use the name/ref of the next non-ramp way
    • if the maneuver is at a motorway_junction, use the name/ref of the motorway_junction.

Deciding between the last two might be a bit tricky: for a regular exit, I would prefer the name/ref of the exit. For a junction (changing from one motorway to another), I would prefer to have the name/ref of the motorway to which I am about to change. We might be able to solve this by looking at the route members following the maneuver up to the first non-ramp: if it is a motorway, use its name/ref; in all other cases, use that of the junction. (Of course, if one of the two is not available, use the other instead.)

aerostitch commented 9 years ago

2014-11-04 11:53:03: @jandegr commented

This is handled in #1082 and code for testing is already provided and the changes in maptool to allow this are already committed to SF (5980), so I vote to close this ticket.

aerostitch commented 9 years ago

2014-11-04 11:53:03: @jandegr

aerostitch commented 9 years ago

2014-11-04 11:53:03: @jandegr