aerostitch / testnavit

0 stars 0 forks source link

path in map_secondary_sdcard_navitmap_bin.xslt is wrong #234

Open aerostitch opened 10 years ago

aerostitch commented 10 years ago

Issue migrated from trac ticket # 1218

component: core | priority: major

2014-06-24 03:05:52: christoph.thielecke@gmail.com created the issue


The path to secondary sdcard on android is wrong. In navit/xslt/map_secondary_sdcard_navitmap_bin.xslt you can see:

<?xml version="1.0"?>
<xsl:transform version="2.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:xi="http://www.w3.org/2001/XInclude">
        <xsl:template match="/config/navit/mapset/xi:include">
                <map type="binfile" enabled="yes" data="/sdcard/navit/navitmap.bin" />
                <xsl:text>&#x0A;                        </xsl:text>
                <map type="binfile" enabled="yes" data="/sdcard/navit/navitmap_002.bin" />
        </xsl:template>
</xsl:transform>

There are 2 paths: /sdcard/navit/navitmap.bin and /sdcard/navit/navitmap_002.bin which point to /sdcard which should be /mnt/extSdCard on android.

I provide a patch for fixing the paths (map_secondary_sdcard_navitmap_bin.xslt_android_path_fix.patch).

Also, I guess it's better to use *.bin instead of hardcoded path name for the maps, for fixing the file I provide another patch which change the path to external sdcard and use the pattern (map_secondary_sdcard_navitmap_bin.xslt_android_path_fix_all_bin.patch)

svn is at rev 5795.

aerostitch commented 10 years ago

2014-06-24 03:08:41: christoph.thielecke@gmail.com uploaded file map_secondary_sdcard_navitmap_bin.xslt_android_path_fix.patch (0.8 KiB)

Fix paths of external sdcard on android

aerostitch commented 10 years ago

2014-06-24 03:09:16: christoph.thielecke@gmail.com uploaded file map_secondary_sdcard_navitmap_bin.xslt_android_path_fix_all_bin.patch (0.7 KiB)

Fix path of external sdcard on android using global pattern for mapfile

aerostitch commented 7 years ago

2017-08-13 23:14:09: @jkoan commented


As I know it is not standardized where the mount on Android is. Exactly because we have so much different devices. Probably it is possible to autodetect the paths.