search

aerostitch / testnavit

0 stars 0 forks source link

Multipolygon relations not handled correctly #65

Open aerostitch opened 13 years ago

aerostitch commented 13 years ago

Issue migrated from trac ticket # 754

component: tools | priority: major | keywords: multi, poly, water, coast

2011-01-27 23:49:22: jrahe created the issue

settlement (landuse=residential type=multipolygon) will not be displayed (colored) on the map.[[BR]]

example 1: http://www.openstreetmap.org/browse/relation/1304643[[BR]]

example 2: http://www.openstreetmap.org/browse/relation/1347636

Maybe similar problem like multipolygons for natural=water (http://trac.navit-project.org/ticket/689)

settlement (landuse=residential) are ok.[[BR]]

example 3: http://www.openstreetmap.org/browse/way/87861851[[BR]]

example 4: http://www.openstreetmap.org/browse/way/24961414

Greetings Jörg

aerostitch commented 12 years ago

2012-03-20 10:30:06: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-20 13:20:52: rico@bierrommel.de commented

Replying to [comment:83 wakefred]: Thanks, I didn't notice it. It means, all MPs in this area are defect. I will change it in osm as soon as possible.

Rico

aerostitch commented 12 years ago

2012-03-21 02:16:51: wakefred@gmail.com commented

@tegzed... ufff... maptool is still at work for the planet - since yesterday at 16:00 h. I hope, this time, the space of the VM is big enough: the tmp-files needs really a lot of space for the whole planet.

aerostitch commented 12 years ago

2012-03-21 12:48:26: rdzidlic@googlemail.com commented

polygon_hole.diff is against 4971 which is a bit unlucky because that snapshot is not in the snapshots repository (http://download.navit-project.org/navit/src/svn/). It does not apply cleanly to 4977 or 4979. Does it work cleanly with any other snapshots that are downloadable as tarballs?

aerostitch commented 12 years ago

2012-03-21 13:34:44: wakefred@gmail.com commented

@rdzidlic... I've tested this patch also with svn-4972: there it works cleanly (the maptool/CMakeLists.txt can be skipped, because it isn't necessary there).

aerostitch commented 12 years ago

2012-03-21 13:34:44: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-21 13:34:44: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-21 14:48:37: rdzidlic@googlemail.com commented

Replying to [comment:87 wakefred]:

@rdzidlic... I've tested this patch also with svn-4972: there it works cleanly (the maptool/CMakeLists.txt can be skipped, because it isn't necessary there).

what am I doing wrong? Is some other patch needed or something else?

$ tar xvzf ../SOURCES/navit-svn-4972.tar.gz
$ cd navit-0.5.0/
$ patch -p0 --dry-run <../../SOURCES/polygon_hole.diff
patching file maptool/osm.c
Hunk #1 FAILED at 670.
Hunk #2 FAILED at 707.
Hunk #3 FAILED at 940.
Hunk #4 FAILED at 1480.
Hunk #5 FAILED at 1551.
Hunk #6 FAILED at 2560.
Hunk #7 FAILED at 2575.
Hunk #8 FAILED at 2590.
8 out of 8 hunks FAILED -- saving rejects to file maptool/osm.c.rej
patching file maptool/maptool.c
Hunk #1 FAILED at 745.
1 out of 1 hunk FAILED -- saving rejects to file maptool/maptool.c.
patching file maptool/maptool.h
Hunk #1 FAILED at 121.
Hunk #2 FAILED at 187.
Hunk #3 FAILED at 240.
3 out of 3 hunks FAILED -- saving rejects to file maptool/maptool.h
patching file maptool/itembin_buffer.c
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file maptool/itembin_bu
patching file maptool/seidel/tri.c
patching file maptool/seidel/monotone.c
patching file maptool/seidel/misc_seidel.c
patching file maptool/seidel/construct.c
patching file maptool/seidel/triangulate.h
patching file maptool/seidel/interface.h
patching file maptool/geom.c
Hunk #1 FAILED at 19.
Hunk #2 FAILED at 357.
Hunk #3 FAILED at 620.
3 out of 3 hunks FAILED -- saving rejects to file maptool/geom.c.re
patching file maptool/Makefile.am
Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file maptool/Makefile.a
patching file maptool/boundaries.c
Hunk #1 FAILED at 19.
Hunk #2 FAILED at 70.
Hunk #3 FAILED at 192.
Hunk #4 FAILED at 228.
Hunk #5 FAILED at 246.
5 out of 5 hunks FAILED -- saving rejects to file maptool/boundarie
patching file maptool/CMakeLists.txt
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file maptool/CMakeLists
patching file attr_def.h
Hunk #1 FAILED at 429.
1 out of 1 hunk FAILED -- saving rejects to file attr_def.h.rej
patching file attr.c
Hunk #1 FAILED at 492.
1 out of 1 hunk FAILED -- saving rejects to file attr.c.rej
patching file graphics.c
Hunk #1 FAILED at 50.
Hunk #2 FAILED at 402.
Hunk #3 FAILED at 452.
Hunk #4 FAILED at 860.
Hunk #5 FAILED at 876.
Hunk #6 FAILED at 889.
Hunk #7 FAILED at 910.
Hunk #8 FAILED at 1727.
Hunk #9 FAILED at 1741.
Hunk #10 FAILED at 2089.
Hunk #11 FAILED at 2110.
Hunk #12 FAILED at 2128.
12 out of 12 hunks FAILED -- saving rejects to file graphics.c.rej
aerostitch commented 12 years ago

2012-03-22 00:07:17: wakefred@gmail.com commented

@rdzidlic... your pc don't patch the subfolders... Ubuntu have in some cases this problem. I have uploaded a patched svn-version, if you like: http://dl.artpc.ch/navit/navit-svn/navit-svn-4972_with_polygonhole_patch.tar.gz

aerostitch commented 12 years ago

2012-03-22 00:23:36: wakefred@gmail.com commented

@tegzed... maptool is still at work for the planet. But I have the attached message in the terminal, but the CPU is still on 100% and the wayssplit.tmp is actualised 3 minutes ago. so I think, maptool is still normal at working.[[BR]]

...
OSM Warning:http://www.openstreetmap.org/browse/relation/307573 Broken country polygon 'pk'
OSM Warning:http://www.openstreetmap.org/browse/relation/536807 Broken country polygon 'lk'
add_segment: error
newtrap: Trapezoid-table overflow
newnode: Query-table overflow
newnode: Query-table overflow
newtrap: Trapezoid-table overflow
newnode: Query-table overflow
newnode: Query-table overflow
... (about 20 lines with newnode or newtrap)
newtrap: Trapezoid-table overflow
newnode: Query-table overflow
newnode: Query-table overflow
newtrap: Trapezoid-table overflow
newnode: Query-table overflow
newnode: Query-table overflow
newtrap: Trapezoid-table overflow
add_segment: error
aerostitch commented 12 years ago

2012-03-22 01:04:51: tegzed commented

It seems that this error is caused by huge polygons. These polygons will be filtered out and hopefully will cause fatal errors.

aerostitch commented 12 years ago

2012-03-22 23:30:15: wakefred@gmail.com commented

@tegzed... the planet don't work. maptool aborted after 60 hours of work with the following message:

./navitmap-planet: Zeile 8: 12145 Speicherzugriffsfehler  maptool --protobuf -i planet-latest.osm.pbf navitmap-planet.bin
aerostitch commented 12 years ago

2012-03-23 04:06:14: tegzed commented

@wakefred Thanks for testing, I will implement some fix for the above errors which will hopefully solve the problem.

aerostitch commented 12 years ago

2012-03-23 15:53:04: rdzidlic@googlemail.com commented

@wakefred: thanks for the tips, got latest patch, run autoreconf, tweaked a little bit and it compiles.

However I still can not see this lake: http://www.openstreetmap.org/?lat=48.39796&lon=11.60715&zoom=17&layers=M

wget -c --proxy=off "http://api.openstreetmap.org/api/0.6/map?bbox=11.60349,48.39469,11.61081,48.40123"
maptool kranzberg.bin  <map\?bbox\=11.60349\,48.39469\,11.61081\,48.40123

regarding the "Speicherzugriffsfehler" when you were building the whole planet - is it possible that maptool run out of memory?

aerostitch commented 12 years ago

2012-03-24 01:11:40: wakefred@gmail.com commented

@rdzidlic... you can't see this lake, because there is no multipolygon. maptool is rendering the landuse=scrub over the natural=water. there should be a multipolygon with the landuse=scrub as outer and the natural=water as inner. then it will be visible (the same with the little lake on the left side of this lake: tag it as MP; the lake as inner and the meadow as outer).

@all... friday night till saturday at 10:15 am my domain dl.artpc.ch wasn't available. But now, its available again and you can download the maps again.

aerostitch commented 12 years ago

2012-03-24 01:11:40: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-24 01:11:40: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-24 01:11:40: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-25 22:29:33: wakefred@gmail.com commented

All right... I make today over the day new maps for AT, CH, DE, LI, DACH, Benelux and British Isles. And at 16:00 h, I'll start the planet, again.

aerostitch commented 12 years ago

2012-03-25 22:29:33: wakefred@gmail.com

aerostitch commented 12 years ago

2012-03-26 08:16:09: wakefred@gmail.com commented

@all... Switzerland looks good. I hope, there will be other people to check other countries.[[BR]] @tegzed... just for information: maptool is now much slower with this new patch, than with the polygon_hole.diff from last week (I think, maptool needs about 15% more time than last week).

aerostitch commented 12 years ago

2012-03-26 12:45:03: korrosa commented

New British Isles works fine for me...

aerostitch commented 12 years ago

2012-03-27 01:28:33: wakefred@gmail.com commented

@tegzed... the planet don't work. maptool aborted after ~12 hours with a "Speicherzugriffsfehler". see the last ~50 lines:

OSM Warning:http://www.openstreetmap.org/browse/relation/1987925 Unknown role axis in member http://www.openstreetmap.org/browse/way/147221667 
OSM Warning:http://www.openstreetmap.org/browse/relation/1993208 Country Boundary doesn't contain an ISO3166-1 tag
OSM Warning:http://www.openstreetmap.org/browse/relation/1993867 Country Boundary doesn't contain an ISO3166-1 tag
OSM Warning:http://www.openstreetmap.org/browse/relation/1996871 Unknown role admin_centre in member http://www.openstreetmap.org/browse/way/56467378 
OSM Warning:http://www.openstreetmap.org/browse/relation/2019026 Unknown role yes in member http://www.openstreetmap.org/browse/way/149792189 
OSM Warning:http://www.openstreetmap.org/browse/relation/2019250 Unknown role yes in member http://www.openstreetmap.org/browse/way/149818946 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852366 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852384 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852322 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852314 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852306 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852302 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852361 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852297 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852330 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852392 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852398 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852337 
OSM Warning:http://www.openstreetmap.org/browse/relation/2032957 Unknown role  inner in member http://www.openstreetmap.org/browse/way/150852342 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060298 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060260 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060261 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060281 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060263 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060262 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060266 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060269 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060271 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151060272 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role  inner in member http://www.openstreetmap.org/browse/way/151060273 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060302 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060306 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060308 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060315 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060318 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060319 
OSM Warning:http://www.openstreetmap.org/browse/relation/2035909 Unknown role   outer in member http://www.openstreetmap.org/browse/way/151060261 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093058 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093060 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093061 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093062 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/152517650 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093063 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  outer in member http://www.openstreetmap.org/browse/way/151093146 
OSM Warning:http://www.openstreetmap.org/browse/relation/2036496 Unknown role  inner in member http://www.openstreetmap.org/browse/way/151093201 
OSM Warning:http://www.openstreetmap.org/browse/relation/2063615 Unknown role nt in member http://www.openstreetmap.org/browse/way/137325269 
OSM Info:http://www.openstreetmap.org/browse/relation/2067731 Country Boundary for 'th'
OSM Info:http://www.openstreetmap.org/browse/relation/2088990 Country Boundary for 'RS'
OSM Warning:http://www.openstreetmap.org/browse/relation/2090329 Unknown role innrt in member http://www.openstreetmap.org/browse/way/155787948 
OSM Warning:http://www.openstreetmap.org/browse/relation/2090329 Unknown role innrt in member http://www.openstreetmap.org/browse/way/155787938 
add_segment: error
OSM Warning:http://www.openstreetmap.org/browse/relation/49898 Broken country polygon 'kh'
OSM Warning:http://www.openstreetmap.org/browse/relation/184843 Broken country polygon 'lb'
OSM Warning:http://www.openstreetmap.org/browse/relation/192691 Broken country polygon 'ma'
OSM Warning:http://www.openstreetmap.org/browse/relation/192757 Broken country polygon 'tn'
OSM Warning:http://www.openstreetmap.org/browse/relation/192788 Broken country polygon 'td'
OSM Warning:http://www.openstreetmap.org/browse/relation/192830 Broken country polygon 'cm'
OSM Warning:http://www.openstreetmap.org/browse/relation/195270 Broken country polygon 'tz'
OSM Warning:http://www.openstreetmap.org/browse/relation/195838 Broken country polygon 'eh'
OSM Warning:http://www.openstreetmap.org/browse/relation/270056 Broken country polygon 'cn'
OSM Warning:http://www.openstreetmap.org/browse/relation/272644 Broken country polygon 've'
OSM Warning:http://www.openstreetmap.org/browse/relation/288247 Broken country polygon 'pe'
OSM Warning:http://www.openstreetmap.org/browse/relation/304716 Broken country polygon 'in'
OSM Warning:http://www.openstreetmap.org/browse/relation/307573 Broken country polygon 'pk'
./navitmap-planet: Zeile 8:  6390 Speicherzugriffsfehler  maptool --protobuf -i planet-latest.osm.pbf navitmap-planet.bin
aerostitch commented 12 years ago

2012-04-01 13:59:24: tegzed uploaded file polygon_hole.diff (99.8 KiB)

fixed intersection detection for horizontal and vertical lines

aerostitch commented 12 years ago

2012-04-02 04:31:46: wakefred@gmail.com commented

thanks tegzed... (cool, that you're updated to svn-5005... so the meadows would also be rendered now.[[BR]] I'll try the planet this evening again.

aerostitch commented 12 years ago

2012-04-02 05:46:15: tegzed commented

Hi Wakefred,

The planet will probably crash with this patch too, we still have at least one bug that will prevent building planet with this patch. The triangulator code is very touchy about the input polygons and I keep running into exotic cases. Hopefully I can eliminate all the problemmatic cases soon.

aerostitch commented 12 years ago

2012-04-02 06:04:51: tegzed commented

One problemmatic polygon is http://www.openstreetmap.org/?relation=1175564 but when I try to export this area from the osm the server gives me an error. I would need a small extract to fix a bug so I don't need to wait more than one day to debug this poly. Can anybody get osm xlm data for this area?

aerostitch commented 12 years ago

2012-04-02 06:49:36: korrosa commented

On Sunday 1st April OSM changed its licensing from CC-BY-SA to ODBL. The servers are currently undergoing maintenance until April 4th, so service will be poor.

aerostitch commented 12 years ago

2012-04-02 07:21:26: wakefred@gmail.com commented

I can extract this area tomorrow morning from the planet, if you like. But you can't upload a changed polygon till 04.April, because the OSM-database is at the moment just in a read-only-mode.

aerostitch commented 12 years ago

2012-04-02 07:55:33: tegzed commented

I just want the osm xlm data for testing an as small as possible area, I don't want to upload any modifications to osm. It would be very helpful for me if you could extract this area from the planet.

aerostitch commented 12 years ago

2012-04-02 23:21:46: wakefred@gmail.com commented

@tegzed... the planet is still at work. and the multipolygon 1175564 is attached: http://trac.navit-project.org/attachment/ticket/754/defect_multipolygon.osm

aerostitch commented 12 years ago

2012-04-03 00:12:28: wakefred@gmail.com uploaded file defect_multipolygon.osm (17.8 KiB)

for testing

aerostitch commented 12 years ago

2012-04-03 02:27:45: wakefred@gmail.com commented

@tegzed... as you said: the planet don't work.[[BR]] Message:

./navitmap-planet: Zeile 8: 15647 Speicherzugriffsfehler  maptool --protobuf -i planet-latest.osm.pbf navitmap-planet.bin
aerostitch commented 12 years ago

2012-05-16 22:36:52: rico@bierrommel.de commented

Is there any chance to get the patch into svn?

aerostitch commented 12 years ago

2012-05-18 12:04:44: tegzed commented

Hi Rico,

I need to fix some problems with the patch since planet osm crashes with it and arrange the code to a better shape. These weeks I'm quite busy but I hope to find the time for this soon.

aerostitch commented 11 years ago

2013-06-12 10:02:07: usul commented

Over at the new forum, somebody asks if/when this patch can be applied or if there are other workarounds: https://forum.navit-project.org/viewtopic.php?f=4&t=396

aerostitch commented 11 years ago

2013-06-12 10:21:50: rico@bierrommel.de commented

I tried to adapt the patch to svn 5532 and it seems to works at least for germany. http://linux.bierrommel.de/dateien/navit/multipolygon.patch

aerostitch commented 11 years ago

2013-06-16 01:03:22: tryagain commented

Hi,

As tegzed said in http://trac.navit-project.org/ticket/754#comment:109, this patch will crash on the whole planet. Though I have not verified that.

As far as I can see from the code, it makes one navit item from the whole relation. For large rivers/lakes, these objects can be quite big in terms of node count (resulting in tens or even hundreds of kilobytes size). Also, large objects will cross tiles boundaries so they will be put into the upper level tiles, significantly affecting all map operations on the target device. For example, a river crossing the Equator will be processed even when you're in Germany, resulting in raised memory requirements and slowed down processing speed.

So I think we should consider another approach, similar to the one used in coastline processing. Whole set of ways tagged natural=coastline is very similar to one huge multimegabyte boundary relation. The only difference is that all natural=coastline ways have consistent direction.

But we already have in maptool a function to fix boundary members directions. This mechanism is proven to work on administrative boundary relations and is giving good results now.

I think a working approach would be to mix these two existing solutions: one for administrative boundaries to make each relation look like a coastline set. And then process each resulting "coastline" to split it into the pieces on the tile boundaries.

tryagain.

aerostitch commented 11 years ago

2013-07-06 00:24:44: usul uploaded file Warnow_HRO Navit.png (168.8 KiB)

Warnow_HRO Navit.png

aerostitch commented 11 years ago

2013-07-06 00:26:07: usul uploaded file Warnow_HRO OSM.jpg (120.4 KiB)

Warnow_HRO OSM.jpg

aerostitch commented 11 years ago

2013-07-06 00:30:39: usul

aerostitch commented 11 years ago

2013-07-06 00:30:39: usul commented

Maybe this area in Germany can be a good usecase:

[[Image(Warnow_HRO OSM.jpg)]]

[[Image(Warnow_HRO Navit.png)]]

I had a chat with cp15 and he said that there is some algorithm to draw multipolygones the right way, without the need to do some preprocessing (as far as I understood).

As this issue might confuse users and think that Navit is broken, I schedule it to next hotfix release 0.5.1

aerostitch commented 6 years ago

2017-12-02 04:08:44: @jkoan

aerostitch commented 6 years ago

2017-12-02 04:08:44: @jkoan commented

This ticket was pushed back in order to bring 0.5.1 out soon.