search

aertslab / RcisTarget

RcisTarget: Transcription factor binding motif enrichment
34 stars 9 forks source link

Version bug with `addLogo` function giving wrong logo URLs #36

Open ycl6 opened 1 year ago

ycl6 commented 1 year ago

There's a bug with the addLogo function were the dbVersion always ended up with v10 and not the previous v9 when old version of the database is used.

https://github.com/aertslab/RcisTarget/blob/33623d40f1ad4b4c21f510d570183328cf06eafe/R/aux_addLogo.R#L22-L44

In Line 28-35, the code already assigned v9 to dbVersion if previous version is detected.

https://github.com/aertslab/RcisTarget/blob/33623d40f1ad4b4c21f510d570183328cf06eafe/R/aux_addLogo.R#L28-L35

But the next if/else reset it back to v10nr_clust because dbVersion is not NULL. The lead to wrong URLs to the motif logos embedded in the HTML.

https://github.com/aertslab/RcisTarget/blob/33623d40f1ad4b4c21f510d570183328cf06eafe/R/aux_addLogo.R#L37-L44

YachengPan commented 10 months ago

Do you have any methods to solve this bug? I encounter the same bug. Look forword to your reply.

19301050043 commented 1 month ago

I got the same erro, do you have any method