Closed MaybeJustJames closed 3 years ago
Add PR summary points to documentation (conribution manual??)
/!\ I noticed that <- Pevious
and Next ->
buttons of the cluster controls (right side bar) don't work anymore. They work in the master
branch
/!\ I noticed that
<- Pevious
andNext ->
buttons of the cluster controls (right side bar) don't work anymore. They work in themaster
branch
Reproductions steps:
@dweemx wrt an .nvmrc
Node 10 is EOL end of this month. I'm fine leaving this out. What about you?
@dweemx Can you elaborate on what "switch from loom" means?
@dweemx wrt an
.nvmrc
Node 10 is EOL end of this month. I'm fine leaving this out. What about you?
You mean not having a .nvmrc
file or just upgrade to use higher Node version ?
@dweemx wrt an
.nvmrc
Node 10 is EOL end of this month. I'm fine leaving this out. What about you?You mean not having a
.nvmrc
file or just upgrade to use higher Node version ?
No I mean it's a users fault if they use an EOL node version. So why have an .nvmrc
?
@dweemx wrt an
.nvmrc
Node 10 is EOL end of this month. I'm fine leaving this out. What about you?You mean not having a
.nvmrc
file or just upgrade to use higher Node version ?No I mean it's a users fault if they use an EOL node version. So why have an
.nvmrc
?
Because the user will be sure that the software will work with that version of Node.
This branch begins a large-scale move of the app to redux and redux sagas for state management. It also restructures the app in a way I think is easier to navigate and think about.
Cleanup
fetch()
And GProfiler previously introduced.jest-css-modules-transform
to handle imports for CSS. Version is intentionally pinned as "4.0.2" breaks tests.LegacyAPI
nameApp
component in newMain
andFullPageNotify
components.zipLists
tozip()
a list of lists.default exports
Code structure and redesign
getFeature()
requests and responsesgetFeature()
requestsimmer
to update Redux state.Result
type similar to the backendResult
type.UI
Breaking changes and known issues
This PR breaks ViewerSidebar "Clustering Controls". Fixing this is out of scope for the PR, this should instead be fixed after @dweemx cleanup of the ViewerSidebar is merged.Compare tab break when performing a DnD of one of the annotation onto a viewer.