aertslab / SCope

Fast visualization tool for large-scale and high dimensional single-cell data
GNU General Public License v3.0
68 stars 15 forks source link

Initial front-end restructure and code re-design #381

Closed MaybeJustJames closed 3 years ago

MaybeJustJames commented 4 years ago

This branch begins a large-scale move of the app to redux and redux sagas for state management. It also restructures the app in a way I think is easier to navigate and think about.

Cleanup

Code structure and redesign

UI

Breaking changes and known issues

MaybeJustJames commented 4 years ago

Add PR summary points to documentation (conribution manual??)

dweemx commented 4 years ago

/!\ I noticed that <- Pevious and Next -> buttons of the cluster controls (right side bar) don't work anymore. They work in the master branch

MaybeJustJames commented 3 years ago

/!\ I noticed that <- Pevious and Next -> buttons of the cluster controls (right side bar) don't work anymore. They work in the master branch

Reproductions steps:

  1. Query "Unannotated Cluster 0"
  2. Click on "Next ->" button in the right side bar should take you to the next cluster i.e.: "Unannotated Cluster 1"
  3. Click on "<- Previous" button in the right side bar should take you to the previous cluster i.e.: "Unannotated Cluster 0"
MaybeJustJames commented 3 years ago

@dweemx wrt an .nvmrc Node 10 is EOL end of this month. I'm fine leaving this out. What about you?

MaybeJustJames commented 3 years ago

@dweemx Can you elaborate on what "switch from loom" means?

dweemx commented 3 years ago

@dweemx wrt an .nvmrc Node 10 is EOL end of this month. I'm fine leaving this out. What about you?

You mean not having a .nvmrc file or just upgrade to use higher Node version ?

MaybeJustJames commented 3 years ago

@dweemx wrt an .nvmrc Node 10 is EOL end of this month. I'm fine leaving this out. What about you?

You mean not having a .nvmrc file or just upgrade to use higher Node version ?

No I mean it's a users fault if they use an EOL node version. So why have an .nvmrc?

dweemx commented 3 years ago

@dweemx wrt an .nvmrc Node 10 is EOL end of this month. I'm fine leaving this out. What about you?

You mean not having a .nvmrc file or just upgrade to use higher Node version ?

No I mean it's a users fault if they use an EOL node version. So why have an .nvmrc?

Because the user will be sure that the software will work with that version of Node.