Use the sanctuary Either type instead of the custom Result type

aertslab / SCope

Fast visualization tool for large-scale and high dimensional single-cell data

GNU General Public License v3.0

68 stars 15 forks source link

Use the sanctuary Either type instead of the custom Result type #469

Closed MaybeJustJames closed 3 years ago

MaybeJustJames commented 3 years ago

Sanctuary's Either is well tested and matches the Fantasyland spec the Ramda also conforms to which our Result did not. Therefore this is a good candidate to remove unnecessary code. I do not expect the production bundle size to increase at all thanks to tree shaking.

MaybeJustJames commented 3 years ago

The current release of Sanctuary depends on nodes util library. This is fixed on their master branch but is, as yet, unreleased. Therefore this PR is being closed until Sanctuary roles a release with this fixed.