search

aertslab / SCope

Fast visualization tool for large-scale and high dimensional single-cell data
GNU General Public License v3.0
69 stars 14 forks source link

Client authentication #500

Closed MaybeJustJames closed 2 years ago

MaybeJustJames commented 2 years ago

Integrates login to the client. Also updates to react-routerv6, changes are as lazy as possible (so break a lot of features)

MaybeJustJames commented 2 years ago

@KrisDavie note that the SemGrep issues weren't introduced in this PR

MaybeJustJames commented 2 years ago

@kverstae Thanks for having a look at this! Your review is very helpful and insightful.

There are 2 things that might be useful to add to the authentication as well:

  1. Persisting authentication status. When you now refresh the page, authentication status is lost. Not really an issue since most users don't manually refresh there page, but would be nice if you could remain logged in after leaving the page. (#507)

I have some code ready to do this in a follow up PR.

  1. Ability to log out. For now you can just refresh the page to do this, but a dedicated button would be nicer.

Indeed of course. That will be a TODO item. (#508)

These changes are not necessarily needed in this PR. If they seem interesting enough, they can be added to the TODOs aswell

Indeed I'd like to avoid any further PR rot.