aertslab / SCopeLoomR

R package (compatible with SCope) to create generic .loom files and extend them with other data e.g.: SCENIC regulons, Seurat clusters and markers, ...
MIT License
40 stars 15 forks source link

Inconsistency between get_ and add_ regulons (AUC) #27

Closed s-aibar closed 4 years ago

s-aibar commented 4 years ago

get_regulons_AUC is not able to read the matrix written by add_scenic_regulons_auc_matrix.

I think the problem is that get_regulons_AUC uses the argument column.attr.name="MotifRegulonsAUC", while add_scenic_regulons_auc_matrix uses a global attribute :

    loom = loom,
    key = CA_REGULONS_AUC,
    value = as.data.frame(x = t(x = regulons.AUC))
  )

(By the way, it could be good to add an alias to keep both names consistent. i.e. add_regulons_AUC <- add_scenic_regulons_auc_matrix <- function() ... )

dweemx commented 4 years ago

Fix in e193e154de5d8d8d72c87da14ee3a5f51715d22e