aertslab / scenicplus

SCENIC+ is a python package to build gene regulatory networks (GRNs) using combined or separate single-cell gene expression (scRNA-seq) and single-cell chromatin accessibility (scATAC-seq) data.
Other
167 stars 27 forks source link

typos in pbmc tutorial #114

Open alexlenail opened 1 year ago

alexlenail commented 1 year ago
  1. tutorial reads:

    from scenicplus.scenicplus_class import create_SCENICPLUS_object
    import numpy as np
    scplus_obj = create_SCENICPLUS_object(
    GEX_anndata = adata.raw.to_adata(),
    cisTopic_obj = cistopic_obj,
    menr = menr,
    bc_transform_func = lambda x: f'{x}-10x_pbmc' #function to convert scATAC-seq barcodes to scRNA-seq ones
    )
    scplus_obj.X_EXP = np.array(scplus_obj.X_EXP.todense())
    scplus_obj

    but the comment above is wrong: actually bc_transform_func works the other direction:

    bc_transform_func: func
        A function used to transform gene expression barcode layout to chromatin accessbility layout.
        default: None
  2. Tutorial reads:

Here we will use the wrapper function. For more information on the different steps, see the following tutorial: TO BE ADDED.

That "to be added" can probably link to this tutorial now: https://scenicplus.readthedocs.io/en/latest/Scenicplus_step_by_step-RTD.html

SeppeDeWinter commented 1 year ago

Hi @alexlenail

Thank you for you comments!

I'm working on a new tutorial (development branch), I'll take these things into account.

Best,

Seppe