search

aerys / minko

3D framework for web, desktop and mobile devices.
http://minko.io
Other
906 stars 210 forks source link

Dev #182

Closed cdoty closed 9 years ago

cdoty commented 9 years ago

I updated the Emscripten install script to use the new emsdk_env.bat file on Windows.

I also added an option to disable the clearing of the context on a SceneManager. This allows multiple SceneManagers to be rendered.

warrenseine commented 9 years ago

Thanks a lot.

This looks good. One minor issue is we're using spaces (not tabs) in our coding style. Can you update your pull request?

Also, please make two separate pull requests.

JMLX42 commented 9 years ago

What's the use case for not clearing the context? On Sep 21, 2014 11:40 AM, "Warren Seine" notifications@github.com wrote:

Thanks a lot.

This looks good. One minor issue is we're using spaces (not tabs) in our coding style. Can you update your pull request?

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56293999.

cdoty commented 9 years ago

In my case, it allows me to put the Html overlay in one SceneManager and the game in another and render both SceneManagers. To do this, there needs to be a way to prevent a SceneManager from clearing the context.

This seems to be needed with the Html overlay, as there seems to be no way, under Emscripten, to move the Html overlay to another SceneManager, or reliably recreate it.

Jean-Marc Le Roux wrote:

What's the use case for not clearing the context? On Sep 21, 2014 11:40 AM, "Warren Seine" notifications@github.com wrote:

Thanks a lot.

This looks good. One minor issue is we're using spaces (not tabs) in our coding style. Can you update your pull request?

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56293999.

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56294822.

cdoty commented 9 years ago

Yep, I'll update that.

Warren Seine wrote:

Thanks a lot.

This looks good. One minor issue is we're using spaces (not tabs) in our coding style. Can you update your pull request?

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56293999.

JMLX42 commented 9 years ago

In my case, it allows me to put the Html overlay in one SceneManager and the game in another and render both SceneManagers.

Why would you do this?

Regards,

On Sun, Sep 21, 2014 at 8:41 PM, Charles Doty notifications@github.com wrote:

Yep, I'll update that.

Warren Seine wrote:

Thanks a lot.

This looks good. One minor issue is we're using spaces (not tabs) in our coding style. Can you update your pull request?

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56293999.

— Reply to this email directly or view it on GitHub https://github.com/aerys/minko/pull/182#issuecomment-56308130.

Jean-Marc Le Roux

Founder and CEO of Aerys (http://aerys.in)

Blog: http://blogs.aerys.in/jeanmarc-leroux Cell: (+33)6 20 56 45 78 Phone: (+33)9 72 40 17 58

cdoty commented 9 years ago

I've converted the tabs into spaces.

JMLX42 commented 9 years ago

1) please separate the pull request into 2 different pull request: just 1 pull request per feature 2) I still don't see any use case in having two scene managers, so that pull request is likely to be turned down