Closed dletozeun closed 9 years ago
Thanks for the pull request. I think this was already fixed. Can you confirm?
It is strange because I did quite the opposite of this patch. I use emscripten 1.22.0 like recommended in minko documentation.
Emscripten 1.25 is very recent so the documentation might be a little outdated. We always make sure to support the latest Emscripten version included in the Emscripten SDK but cannot afford to support multiple Emscripten versions. If you need to stick with 1.22, then your patch should work just fine, but I cannot merge it on the dev branch, because it would break with Emscripten 1.25.
Oh ok, I am updating to 1.25 right now. I did not need 1.22, I just thought minko was supporting only the 1.22 from the doc http://doc.v3.minko.io/wiki/Targeting_HTML5. Thank you for the fast replies.
I've updated the documentation to reflect the current supported version on dev
.
Hello,
I had to make this changes to successfully build the html5 framework on Windows with the script: build_html5_no_tutorial_no_example.bat
Otherwise there were a mismatch with the signatures of the callbacks implemented in HTTPProtocol class compared to the ones in the emscripten header file. Not sure whether the wrapper methods are still necessary but at least it did build. :)