search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Replace aet aliases with at. #51

Closed twiecki closed 2 years ago

twiecki commented 2 years ago

See https://github.com/aesara-devs/aesara/issues/328 for the motivation.

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (c60958a) into main (abcc618) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          466       466           
  Branches        27        27           
=========================================
  Hits           466       466
Impacted Files Coverage Δ
aehmc/hmc.py 100.00% <100.00%> (ø)
aehmc/metrics.py 100.00% <100.00%> (ø)
aehmc/nuts.py 100.00% <100.00%> (ø)
aehmc/proposals.py 100.00% <100.00%> (ø)
aehmc/termination.py 100.00% <100.00%> (ø)
aehmc/trajectory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abcc618...c60958a. Read the comment docs.

rlouf commented 2 years ago

Yes! I've noticed the aesara documentation still uses aet in many places as well.

twiecki commented 2 years ago

I have a pr to change that too.

On Mon, Jan 10, 2022, 16:26 Rémi Louf @.***> wrote:

Yes! I've noticed the aesara documentation still uses aet in many places as well.

— Reply to this email directly, view it on GitHub https://github.com/aesara-devs/aehmc/pull/51#issuecomment-1008683217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFETGG5OOV6JI262KF35X3UVKQ33ANCNFSM5LS6RR3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

twiecki commented 2 years ago

Changed in aesara by https://github.com/aesara-devs/aesara/pull/728.

rlouf commented 2 years ago

Thank you!