search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Do not return scan `updates` from kernels #53

Closed rlouf closed 2 years ago

rlouf commented 2 years ago

Updates of the random states are now handled automatically in the Scan operator in aesara. We thus do not need to return the updates from the innermost scan loops. This will simplify the code in #48 noticeably.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (e1e09f6) into main (98dde0a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          466       464    -2     
  Branches        27        26    -1     
=========================================
- Hits           466       464    -2
Impacted Files Coverage Δ
aehmc/nuts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ad4ae0...e1e09f6. Read the comment docs.

brandonwillard commented 2 years ago

Updates of the random states are now handled automatically in the Scan operator in aesara. We thus do not need to return the updates from the innermost scan loops.

What change(s) is this referencing?