Closed rlouf closed 2 years ago
Despite the seemingly minimal change,test_nuts_mcse
does not pass anymore which is an indication that something is seriously wrong.
I was thinking about getting rid of all non-mcse tests. As you said, they're flaky as a way to assess the correctness of samples and they take a long time to run.
Merging #56 (b0104d9) into main (46218ef) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head b0104d9 differs from pull request most recent head 56ee318. Consider uploading reports for the commit 56ee318 to get more accurate results
@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 461 461
Branches 24 24
=========================================
Hits 461 461
Impacted Files | Coverage Δ | |
---|---|---|
aehmc/hmc.py | 100.00% <100.00%> (ø) |
|
aehmc/nuts.py | 100.00% <100.00%> (ø) |
|
aehmc/step_size.py | 100.00% <100.00%> (ø) |
|
aehmc/trajectory.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 46218ef...56ee318. Read the comment docs.
Also, we can keep the old tests, but mark them as xfail
(or skip
) until the setup/conditions are made more stable.
Since #55 the inner scans do not use
default_update
s but instead return the inner updates following scan's inner function semantics. In this PR we make kernel return inner updates as well.