search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Fix RaveledParamsMap dtypes #61

Closed rlouf closed 2 years ago

rlouf commented 2 years ago

The dtype of parameters can change as they get successively raveled and unraveled. This is problematic when sampling from the posterior distribution of a model whose observation distribution is discrete. In this PR we add a property to RaveledParamsMap that keeps track of dtypes.

rlouf commented 2 years ago

The test that fails is unrelated to the current PR, it seems related to a recent change in scan_perform.pyx. Indeed all tests passe with aesara==2.7.1 but this particular test fails with aesara>=2.7.2.