search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Do not return window adaptation's `final` #74

Closed rlouf closed 2 years ago

rlouf commented 2 years ago

The window adaptation constructor currently returns three functions:

init_adapt, update_adapt, final_adapt = window_adaptation(
        num_steps, is_mass_matrix_full, initial_step_size, target_acceptance_rate
    )

However, in #66 we handled the final step of the adaptation inside update_adapt and there is thus no need to return the final function. In this PR I remove the function from window_adaptation's returned values.

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (62b6bf7) into main (20363d5) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          541       541           
  Branches        31        31           
=========================================
  Hits           541       541
Impacted Files Coverage Δ
aehmc/window_adaptation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20363d5...62b6bf7. Read the comment docs.