search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Update `ShapeFeature` imports #81

Closed brandonwillard closed 1 year ago

brandonwillard commented 2 years ago

This PR updates the now deprecated ShapeFeature imports (i.e. Aesara >= 2.8.3).

rlouf commented 2 years ago

Tests are currently failing because aesara>=0.8.3 is not available. I assume the change is coming in the next release?

brandonwillard commented 2 years ago

Tests are currently failing because aesara>=0.8.3 is not available. I assume the change is coming in the next release?

Yes, haven't created the release yet.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (b0379f1) compared to base (dde2d83). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head b0379f1 differs from pull request most recent head e18892f. Consider uploading reports for the commit e18892f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 12 -1 Lines 545 542 -3 Branches 32 32 ========================================= - Hits 545 542 -3 ``` | [Impacted Files](https://codecov.io/gh/aesara-devs/aehmc/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aehmc/utils.py](https://codecov.io/gh/aesara-devs/aehmc/pull/81/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWVobWMvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | | | [aehmc/\_\_init\_\_.py](https://codecov.io/gh/aesara-devs/aehmc/pull/81/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWVobWMvX19pbml0X18ucHk=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.