search

aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Update step size dtypes #87

Open brandonwillard opened 1 year ago

brandonwillard commented 1 year ago

In #86, I updated the step size dtypes to int64, but I imagine it would be better to perform that conversion somewhere within AeHMC; however, I don't know the best place for that at the moment.

@rlouf, if you get a minute, tell me where you think an astype could be performed so that users can specify int32 and avoid those Scan casting issues.

Originally posted by @brandonwillard in https://github.com/aesara-devs/aehmc/issues/86#issuecomment-1370220761

rlouf commented 1 year ago

As far as I understand, you cast the number of steps to int64. The high-level entry points of the library, and that you might want to use in a Scan are here:

It seems that you've covered the internal ones already.