Currently the wrong cholesky factor is used to compute momentum samples. This commit fixes that by ensuring solve_triangular solves the correct equation to obtain the right cholesky factor of a 2D mass matrix.
closes #92
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
[x] There is an informative high-level description of the changes.
[x] The description and/or commit message(s) references the relevant GitHub issue(s).
[x] The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR. If your commit description starts with "Fix...", then you're probably making this mistake.
[ ] There are tests covering the changes introduced in the PR.
Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.
Currently the wrong cholesky factor is used to compute momentum samples. This commit fixes that by ensuring
solve_triangular
solves the correct equation to obtain the right cholesky factor of a 2D mass matrix.closes #92
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.