aesara-devs / aehmc

An HMC/NUTS implementation in Aesara
MIT License
33 stars 6 forks source link

Update isort version in pre-commit config file. #95

Closed zoj613 closed 1 year ago

zoj613 commented 1 year ago

Setting up the pre-commit hooks fails due to a bug in isort (see: https://github.com/PyCQA/isort/issues/2083). This commit updates the version to 5.12.0 where this bug was fixed.

closes #94

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

zoj613 commented 1 year ago

We need to make it so that "Check code style" runs when the pre-commit config changes. Right now, the requisite check is being skipped.

Is this a hook specified somewhere? I dont see it in the config.

EDIT: nevermind I see you're referring to the github workflow.

zoj613 commented 1 year ago

@brandonwillard could you check this again. The test failure is the unrelated DisconnectedInputError that was mentioned earlier.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (47e1191) 100.00% compared to head (7a4dd2b) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 544 544 Branches 31 31 ========================================= Hits 544 544 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.