Closed zoj613 closed 1 year ago
@rlouf could you please help diagnose the one failed test test_nuts_mcse
? It appears that the MCSE fails for one of the cases in the NUTS sampler. The changes seem fine and do not appear to change behavior so i'm a little confused.
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
75fd205
) 100.00% compared to head (53f8f8b
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
These updates look great; I'm ready to move forward with them.
These updates look great; I'm ready to move forward with them.
I will still need to look into updating the docstrings. @rlouf any thoughts on these changes?
Merged, because these changes are already very helpful. We can add follow-ups for the docstrings and anything else.
closes #67
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.