search

aesara-devs / aemcmc

AeMCMC is a Python library that automates the construction of samplers for Aesara graphs representing statistical models.
https://aemcmc.readthedocs.io/en/latest/
MIT License
39 stars 11 forks source link

Update `ShapeFeature` imports #55

Closed brandonwillard closed 2 years ago

brandonwillard commented 2 years ago

This PR updates the now deprecated ShapeFeature imports (i.e. Aesara >= 2.8.3).

rlouf commented 2 years ago

Still fails because https://github.com/aesara-devs/aeppl/pull/168 wasn't merged on AePPL.

rlouf commented 2 years ago

I updated the related PR in AePPL that was merged by @ricardoV94. We're one AePPL release away from being able to merge this.

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.35% // Head: 97.35% // No change to project coverage :thumbsup:

Coverage data is based on head (28d228d) compared to base (e579992). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 28d228d differs from pull request most recent head 20f0bfe. Consider uploading reports for the commit 20f0bfe to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ======================================= Coverage 97.35% 97.35% ======================================= Files 9 9 Lines 606 606 Branches 63 63 ======================================= Hits 590 590 Misses 5 5 Partials 11 11 ``` | [Impacted Files](https://codecov.io/gh/aesara-devs/aemcmc/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aemcmc/rewriting.py](https://codecov.io/gh/aesara-devs/aemcmc/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWVtY21jL3Jld3JpdGluZy5weQ==) | `98.67% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.