aesara-devs / aeppl

Tools for an Aesara-based PPL.
https://aeppl.readthedocs.io
MIT License
64 stars 20 forks source link

Implement log-probability for `StudentTRV` #199

Closed rlouf closed 2 years ago

rlouf commented 2 years ago

Follows the addition of StudentTRV in Aesara in https://github.com/aesara-devs/aesara/pull/1211. Closes #185.

This is a draft, with no guarantee that the results are correct; the tests need to be expanded.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

codecov[bot] commented 2 years ago

Codecov Report

Base: 95.16% // Head: 95.18% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (c4ffb39) compared to base (961496a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #199 +/- ## ========================================== + Coverage 95.16% 95.18% +0.01% ========================================== Files 12 12 Lines 1945 1952 +7 Branches 254 254 ========================================== + Hits 1851 1858 +7 Misses 52 52 Partials 42 42 ``` | [Impacted Files](https://codecov.io/gh/aesara-devs/aeppl/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aeppl/logprob.py](https://codecov.io/gh/aesara-devs/aeppl/pull/199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWVwcGwvbG9ncHJvYi5weQ==) | `98.07% <100.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.