search

aesara-devs / aeppl

Tools for an Aesara-based PPL.
https://aeppl.readthedocs.io
MIT License
64 stars 20 forks source link

Replace remaining docstring instances of `factorized_joint_logprob` #228

Closed larryshamalama closed 1 year ago

larryshamalama commented 1 year ago

In #196, factorized_joint_logprob has been renamed to conditional_logprob. However, there are still some occurrences in docstrings where factorized_joint_logprob shows up:

https://github.com/aesara-devs/aeppl/blob/fb6ffc51a282d21d134d691400d477366a3d14cc/aeppl/abstract.py#L80-L82

https://github.com/aesara-devs/aeppl/blob/7890228715320c2d1ff6989ff522829b5d6411ba/aeppl/mixture.py#L273-L275

https://github.com/aesara-devs/aeppl/blob/696effab5df9df3be45c1f7395a54ce35fa1d197/tests/test_dist.py#L412-L413

brandonwillard commented 1 year ago

Thanks for pointing that out!

Kd-Here commented 1 year ago

Can I help in that @brandonwillard Just give little detail of that. It will my first contro to open project

rlouf commented 1 year ago

Of course, you'll just have to replace the occurrences of factorized_joint_logprob with conditional_logprob. Open a PR and we can help you there if you need to.

rlouf commented 1 year ago

Closed by #233