Open rlouf opened 1 year ago
should we keep treu_div
and create one more true_divide
instance, or should we completely replace true_div
with true_divide
?
Since some code probably relies on true_div
we should:
(1) Replace true_div
with true_divide
throughout the codebase
(2) Create a true_div
alias
(3) Add a deprecation warning for those trying to use said alias.
We should open issues for the remaining items.
Numpy provides the following API to perform division element-wise:
While Aesara uses the following names:
My suggestion is thus
s/at.true_div/at.true_divide
s/at.floor_div/at.floor_divide
at.int_div
at.divide
toat.true_divide
And while we're at it:
at.mod
toat.remainder
and setat.mod
as an alias toat.remainder
(like NumPy)at.fmod
As an aside the documentation does not reference the API that is currently implemented, it stills references
truediv
,intdiv
andfloordiv
instead of respectivelytrue_div
,int_div
andfloor_div
.