aesara-devs / aesara

Aesara is a Python library for defining, optimizing, and efficiently evaluating mathematical expressions involving multi-dimensional arrays.
https://aesara.readthedocs.io
Other
1.18k stars 155 forks source link

JAX: Implement geometric RV sampling #1444

Closed Smit-create closed 1 year ago

Smit-create commented 1 year ago

Fixes #1323 Here are a few important guidelines and requirements to check before your PR can be merged:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1444 (552346f) into main (4c74650) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/aesara-devs/aesara/pull/1444/graphs/tree.svg?width=650&height=150&src=pr&token=2HNzVWyxrA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs)](https://codecov.io/gh/aesara-devs/aesara/pull/1444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs) ```diff @@ Coverage Diff @@ ## main #1444 +/- ## ======================================= Coverage 74.81% 74.81% ======================================= Files 194 194 Lines 49995 50007 +12 Branches 10572 10572 ======================================= + Hits 37402 37414 +12 Misses 10267 10267 Partials 2326 2326 ``` | [Impacted Files](https://codecov.io/gh/aesara-devs/aesara/pull/1444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs) | Coverage Δ | | |---|---|---| | [aesara/link/jax/dispatch/random.py](https://codecov.io/gh/aesara-devs/aesara/pull/1444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs#diff-YWVzYXJhL2xpbmsvamF4L2Rpc3BhdGNoL3JhbmRvbS5weQ==) | `100.00% <100.00%> (ø)` | |
rlouf commented 1 year ago

Thank you @Smit-create!