aesara-devs / aesara

Aesara is a Python library for defining, optimizing, and efficiently evaluating mathematical expressions involving multi-dimensional arrays.
https://aesara.readthedocs.io
Other
1.18k stars 155 forks source link

Remove support for Python 3.7 #1483

Closed brandonwillard closed 1 year ago

brandonwillard commented 1 year ago

This PR removes explicit Python 3.7 support.

maresb commented 1 year ago

@brandonwillard, I rebased on main to fix the mypy failure.

I updated the upper Python version in the test matrix to 3.11. If it was deliberate to have it only at 3.10 then we can remove 0107efc. Otherwise we might squash it.

Finally I upgraded the flake8 pre-commit version and removed the respective comment in a separate commit.

maresb commented 1 year ago

If it was deliberate to have it only at 3.10 then we can remove 0107efc.

Ah, right. Numba doesn't yet support 3.11. I'll add a comment.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1483 (20fb999) into main (1da48b5) will increase coverage by 0.04%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/aesara-devs/aesara/pull/1483/graphs/tree.svg?width=650&height=150&src=pr&token=2HNzVWyxrA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs)](https://codecov.io/gh/aesara-devs/aesara/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs) ```diff @@ Coverage Diff @@ ## main #1483 +/- ## ========================================== + Coverage 75.02% 75.06% +0.04% ========================================== Files 194 194 Lines 50102 50102 Branches 12096 12096 ========================================== + Hits 37589 37611 +22 + Misses 10189 10170 -19 + Partials 2324 2321 -3 ``` [see 11 files with indirect coverage changes](https://codecov.io/gh/aesara-devs/aesara/pull/1483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aesara-devs)
brandonwillard commented 1 year ago

Thanks, as always, @maresb!