search

aesara-devs / aesara

Aesara is a Python library for defining, optimizing, and efficiently evaluating mathematical expressions involving multi-dimensional arrays.
https://aesara.readthedocs.io
Other
1.18k stars 155 forks source link

Fix memory leak in `TensorFromScalar` #1519

Closed brandonwillard closed 11 months ago

brandonwillard commented 11 months ago

Closes #1517

codecov[bot] commented 11 months ago

Codecov Report

Merging #1519 (5d9a965) into main (ec4821e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         176      176           
  Lines       49507    49507           
  Branches    11986    11986           
=======================================
  Hits        37117    37117           
  Misses      10089    10089           
  Partials     2301     2301
Files Coverage Δ
aesara/tensor/basic.py 89.99% <100.00%> (ø)
brandonwillard commented 11 months ago

@mattearllongshot, if you can, give this branch a shot and tell me if your profiling results still look good. They should, but it's worth checking again.

mattearllongshot commented 11 months ago

Hello, I can confirm this fixes the leak for me. Thanks for the fix!