aesculus / EVTO-App-Feedback

A project to track bugs and ideas for the EVTO App
MIT License
1 stars 0 forks source link

Destination Waypoint - Split battery display #406

Closed EVGrokker closed 7 years ago

EVGrokker commented 7 years ago

This doesn't look right.

The inspector says that the arrival SoC is 39%, with 20% reserved for local use.

If I add that up, that would be 59%, which doesn't match the displayed combination of yellow and blue.

If I assume there's 39% total battery upon arrival, with 20% earmarked for local use, that matches the graphics, but the '39%/20%' looks wrong.

Suggestions:

destinationreserve

aesculus commented 7 years ago

I'll check out the levels.

The first number should be the arrival SoC without the reserve number. The second number should be the reserve.

The original idea was the SoC you wanted 39% plus the 20% that was going to be added on top. So that is what you are asking for no?

Looks like I need to adjust the battery up a bit

aesculus commented 7 years ago

This has been fixed in V1.2 (27). For some reason any character but the "/" results in the battery not formatting correctly. So for now it stays.

I had to fix the Segment Details panel too. Also it might be off 1% because of some rounding I had to do but who is going to notice? (someone probably)

image

EVGrokker commented 7 years ago

I'd still like to see the font size of the SoC numbers below the battery reduced to match the size of the other metrics, for example Arrival Time.

The slash makes the sequence hard to read. If '+' doesn't format well, here are a couple of other alternatives. Note the space surrounding the separator. 49% • 12% (bullet) 49% | 12% (pipe) 49% ⋮ 12% (vertical ellipsis)

aesculus commented 7 years ago

I posted the picture before I changed the font.

I will continue to investigate alternatives to the "/" character but anything else I try screws up the battery fill. Not sure why that is.

EVGrokker commented 7 years ago

I'm guessing that the problem with the separator overlaying the battery image is a z-ordering problem. I assume that the text is html; how about switching to an even smaller font for the separator to reduce its layout space requirements?

aesculus commented 7 years ago

It's totally weird. Makes no sense.

aesculus commented 7 years ago

I added a space before and after the '+' and it seems to now be OK. Go figure. V1.2 (27)

image

EVGrokker commented 7 years ago

The layout of the split battery numbers looks good, but the relative size compared to the battery and other text in the dialog still looks large.

I think if you formatted it to match the text size of the other bolded text in the Waypoint Inspector it would fit more comfortably.

aesculus commented 7 years ago

The placement of the battery is a bit obtuse. Kind of changes based on the amount of content. It could probably be fixed but that would take some time and I have other fish that need frying.

I can make the font the same size but there are a few worries:

The image below is with a matched font size with the screwed up battery. If you like this size better I will make the change.

image

EVGrokker commented 7 years ago

Independent of the implementation issues, I like the rendering in the image above. I would be in favor of that.

aesculus commented 7 years ago

I like the rendering in the image above

The smaller font then?

EVGrokker commented 7 years ago

Yes for the smaller font.

aesculus commented 7 years ago

Implemented in V1.2 (28)

image

EVGrokker commented 7 years ago

Lovely.