aesculus / EVTO-App-Feedback

A project to track bugs and ideas for the EVTO App
MIT License
1 stars 0 forks source link

My Cars: Proposed layout enhancement #453

Closed EVGrokker closed 7 years ago

EVGrokker commented 7 years ago

v 1.2.0 (37)

The new layout for My Cars is excellent. There's an enhancement I'd like to propose that I think would make it even better.

The proposal is to move the active car picker to the top-most position of the dialog, and move the tab bar below it.

mycarstabbar

aesculus commented 7 years ago

But doesn't the current behavior match what you want? The tabs just state what category you are viewing. The picker changes the car. All the content below the picker is car based.

I could reset the tab to the first one whenever you changed the picker if that would help you.

Otherwise what I am saying is that the app should be working exactly as you want, just that the tabbar is higher up. I think mine looks cleaner but that's debateable (just like my main menu position :-)

EVGrokker commented 7 years ago

The behavior is correct, my comment was only with respect to appearance.

In my mind, the function of a tab is to present related, but separated controls grouped in some meaningful way. There's an implication that each tab contains unique controls.

And I like visual hierarchies that tell the user a story. To me, the car selection is a higher level subject matter to the tab content, which contains all the specific details for that car.

But I'll defer to your decision.

aesculus commented 7 years ago

Happy now? I was saving this for something more important.

image

EVGrokker commented 7 years ago

I applaud your good taste and high standards.

EVGrokker commented 7 years ago

v 1.2.0 (48) I prefer the new layout, as it flows more logically.

It would breathe a bit better if you could increase the amount of space between the tab bar and the content below. In the image below, there should be at least as much space above the 'Payload' and 'Climate Control' labels as there is below. The other two tabs should be adjusted as well.

mycarsspacing

aesculus commented 7 years ago

Fixed in V1.2 (49)

image