search

aesculus / denonavpcontrol

LMS plugin for Denon/Marrantz receivers
14 stars 6 forks source link

Error with synchronized players? #21

Closed bjarteskogoy closed 2 years ago

bjarteskogoy commented 2 years ago

It seems to me that synchronized players causes an error with the latest version. Multiple synchronized players which are not connected to a receiver works OK. A single player connected to receiver works OK.

When synchronizing a player with a connected receiver, playback stops after a few seconds and I find this message in the log: Slim::Utils::Timers::ANON (272) Error: Timer Plugins::DenonAvpControl::Plugin::handleSendPowerOn failed:

SamInPgh commented 2 years ago

I was able to recreate the problem and it appears to be a longstanding one, caused by LMS calling the plugin with a "power on" notification for the synced player, which we should ignore. Thank you for the clear description. In my case, it was easily circumvented by simply restarting playback. Is that your experience also? If so, I will proceed with creating a fix for the next plugin release. Thanks again for reporting this.

SamInPgh commented 2 years ago

If you feel comfortable testing an interim fix, I have attached an updated copy of "Plugin.pm" which can be copied to the DenonAvpControl plugin directory in your LMS installation after renaming the old one to something like Plugin.pm.save. After copying it, you must restart LMS in order to activate it. I would appreciate your feedback on any other issues you run into with the plugin, whether related to this probem or not. Are you aware of the user forum for the plugin? It is the preferred place to report problems rather than here in Github. The link is here.

NOTE: Github forced me to add '.txt' to the filename in order to upload it. You must rename it to "Plugin.pm" when copying to the DenonAvpControl plugin directory.

Plugin.pm.txt

bjarteskogoy commented 2 years ago

Not aware of the forum. The fix seems to solve the problem!

Reestarting playback would help, but it stopped when changing to the next item on the playlist.

SamInPgh commented 2 years ago

The fix seems to solve the problem!

Great! It will be in the next release.

Restarting playback would help, but it stopped when changing to the next item on the playlist.

I'm not sure what you mean by this. Is there still a problem or is this just an observation?

bjarteskogoy commented 2 years ago

Restarting playback would help, but it stopped when changing to the next item on the playlist.

I'm not sure what you mean by this. Is there still a problem or is this just an observation?

That was just an observation, prior to the fix.

SamInPgh commented 2 years ago

The fix will be in the next release of the plugin.

SamInPgh commented 2 years ago

Fixed in v4.6.3.