search

aesefficio / CreateInteriorsMod

https://aesefficio.github.io/CreateInteriorsMod/
GNU General Public License v3.0
8 stars 2 forks source link

Cyan Low Chair has an invalid drop loot table #12

Closed OJofSteel closed 1 year ago

OJofSteel commented 1 year ago

When breaking the Cyan Low Chair, you do not receive a Cyan Low Chair back.

Expected: Breaking a Cyan Low Chair should drop the Cyan Low Chair item.

I believe this happens because of a simple mistype when creating the loot tables, you wrote the drop as interiors:cyan_floor_floor_chair instead of interiors:cyan_floor_chair

Relevant log information:

[22:22:56] [Worker-ResourceReload-7/ERROR]: Couldn't parse element loot_tables:interiors:blocks/cyan_floor_chair com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'interiors:cyan_floor_floor_chair' at net.minecraft.util.GsonHelper.m13866(GsonHelper.java:145) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?] at net.minecraft.util.GsonHelper.m13874(GsonHelper.java:145) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.util.GsonHelper.m13909(GsonHelper.java:153) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootItem$Serializer.m7267(LootItem.java:55) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootItem$Serializer.m7267(LootItem.java:40) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootPoolSingletonContainer$Serializer.m5921(LootPoolSingletonContainer.java:151) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootPoolSingletonContainer$Serializer.m5921(LootPoolSingletonContainer.java:129) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootPoolEntryContainer$Serializer.m7561(LootPoolEntryContainer.java:86) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.entries.LootPoolEntryContainer$Serializer.m7561(LootPoolEntryContainer.java:74) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.GsonAdapterFactory$JsonAdapter.deserialize(GsonAdapterFactory.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1290) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:179) ~[gson-2.10.jar%23107!/:?] at net.minecraft.util.GsonHelper.m13808(GsonHelper.java:463) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.util.GsonHelper.m13836(GsonHelper.java:471) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.LootPool$Serializer.deserialize(LootPool.java:192) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.LootPool$Serializer.deserialize(LootPool.java:189) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1290) ~[gson-2.10.jar%23107!/:?] at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:179) ~[gson-2.10.jar%23107!/:?] at net.minecraft.util.GsonHelper.m13808(GsonHelper.java:463) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.util.GsonHelper.m13845(GsonHelper.java:481) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.LootTable$Serializer.deserialize(LootTable.java:294) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.LootTable$Serializer.deserialize(LootTable.java:291) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23107!/:?] at com.google.gson.Gson.fromJson(Gson.java:1261) ~[gson-2.10.jar%23107!/:?] at net.minecraftforge.common.ForgeHooks.loadLootTable(ForgeHooks.java:871) ~[forge-1.20.1-47.2.1-universal.jar%23499!/:?] at net.minecraftforge.common.ForgeHooks.lambda$getLootTableDeserializer$3(ForgeHooks.java:848) ~[forge-1.20.1-47.2.1-universal.jar%23499!/:?] at net.minecraft.world.level.storage.loot.LootDataType.deserialize(LootDataType.java:45) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at net.minecraft.world.level.storage.loot.LootDataManager.lambda$scheduleElementParse$4(LootDataManager.java:56) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?] at net.minecraft.world.level.storage.loot.LootDataManager.m278660(LootDataManager.java:55) ~[client-1.20.1-20230612.114412-srg.jar%23494!/:?] at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]

a0a7 commented 1 year ago

This issue is fixed indev thanks to @rhysdh540, will be published soon.

a0a7 commented 1 year ago

Fixed in Release v0.5 thanks to @rhysdh540!