search

aesiniath / http-streams

Haskell HTTP client library for use with io-streams
https://hackage.haskell.org/package/http-streams
BSD 3-Clause "New" or "Revised" License
50 stars 48 forks source link

Fixes #18: segfault during SSL connections #19

Closed ixmatus closed 11 years ago

ixmatus commented 11 years ago

Segfaults were occurring on SSL connections due to the lack of using withOpenSSL monad.

istathar commented 11 years ago

So I appreciate your enthusiasm but this pull request is full of changes that have nothing to do with the problem you encountered. If you want to file bugs complaining about my Haskell code, you can do so, though I will say I'm not that excited about most of those changes. As for the problem at #18 we can discuss it there.

AfC

ixmatus commented 11 years ago

I was just making corrections based on what HLint was telling me, I had no intention of stepping on toes. You seem to be taking this personally so I apologize, I'm remarkably grateful for both the amount of work and ingenuity you've put into this project and I by no means am trying to step on toes. If I have, I apologize.

I will put together another pull-request that addresses only the issue at hand.

istathar commented 11 years ago

@ixmatus

I was just making corrections based on what HLint was telling me,

Hey, sure. I stopped using hlint a while ago as all it was doing was taking code (which I had struggled to write and finally been happy with) and making it incomprehensible to me.

I fully realize I could be writing more "advanced" Haskell, but I won't do that if it makes the code unreadable. Perhaps in the future things like fromMaybe will be idiomatic but for now I'm happy with a case statement.

I do appreciate you taking the trouble and interest.

AfC