search

aesiniath / http-streams

Haskell HTTP client library for use with io-streams
https://hackage.haskell.org/package/http-streams
BSD 3-Clause "New" or "Revised" License
50 stars 48 forks source link

error encountered in the wild #91

Open mwotton opened 9 years ago

mwotton commented 9 years ago

Not exactly sure what's going on here - the website appears perfectly cromulent.

mwotton commented 9 years ago

i certainly can't see any reason it should crash the process

istathar commented 9 years ago

Well your assertEqual has the wrong argument order. I assume that's not why you wrote this though.

mwotton commented 9 years ago

Right, it us there because it throws an exception

On Sat, 27 Jun 2015 6:19 pm Andrew Cowie notifications@github.com wrote:

Well your assertEqual has the wrong argument order. I assume that's not why you wrote this though.

— Reply to this email directly or view it on GitHub https://github.com/afcowie/http-streams/pull/91#issuecomment-116163224.

istathar commented 9 years ago

@mwotton Incidentally, I can't merge this pull request as it stands; the test suite doesn't pull from external sites (can't do that from build machines!).

istathar commented 9 years ago

So I've duplicated this. I'd imagine this web server is doing something non compliant in its response headers, but attoparsec is awful at giving you error messages. I had a branch once that tried to plumb (<?>) through the parser code, but it didn't help; our code tends to fail within takeBytes or similar, but that happens when the server is misbehaving. I suppose I should try again.

AfC

P.S. People here want to know what on earth you @mwotton was doing going to the shady website in question :)

mwotton commented 9 years ago

Yeah, not expecting you to merge it - just an easy way of packaging up the awful:)

On Mon, 29 Jun 2015 3:38 am Andrew Cowie notifications@github.com wrote:

@mwotton https://github.com/mwotton Incidentally, I can't merge this pull request as it stands; the test suite doesn't pull from external sites (can't do that from build machines!).

— Reply to this email directly or view it on GitHub https://github.com/afcowie/http-streams/pull/91#issuecomment-116502172.

mwotton commented 9 years ago

I work at meanpath.com, remember? We connect to 160 million sites a day, there's got to be some shady sites in there :)