search

aesmail / kaffy

Powerfully simple admin package for phoenix applications
https://kaffy.fly.dev/admin/
MIT License
1.3k stars 153 forks source link

Fixing CI #265

Closed ghenry closed 1 year ago

ghenry commented 1 year ago

@aesmail

Can I drop some of these:

https://github.com/aesmail/kaffy/blob/master/.github/workflows/ci.yml#L15

failing in all our CI.

Then I want to merge some PRs and add to our CHANGELOG Unreleased section. That OK?

Thanks.

aesmail commented 1 year ago

@ghenry I think we could fairly safely remove Erlang 21 from the tests. We should also include the latest elixir versions (1.13 and 1.14). All versions need to be updated in the CI file honestly. But go ahead 👍🏻

Thank you

aesmail commented 1 year ago

@ghenry maybe we should roughly follow elixir's official compatibility documentation.

Whether we will follow elixir's compatibility or not, we should make that clear in the README.

ghenry commented 1 year ago

Yeah, let's follow that. The issue is we're using ubuntu-latest which as per this doesn't have OTP 21:

https://github.com/erlef/setup-beam#usage

I'll switch use to ubuntu-20.04 which is LTS anyway and good for many years:

https://wiki.ubuntu.com/Releases

That should get us back in the green.

ghenry commented 1 year ago

Yep, all green again. I've added this to our README too:

https://github.com/aesmail/kaffy/commit/101c2ee1339bdf8068c83eae40535bb7f29f37d8

Closing this now. Thanks for the speedy replies!

aesmail commented 1 year ago

Perfect! Thank you!