search

aesmail / kaffy

Powerfully simple admin package for phoenix applications
https://kaffy.fly.dev/admin/
MIT License
1.3k stars 153 forks source link

[FEATURE-REQUEST] - resolve deprecation warnings in Phoenix 1.7 #280

Closed arcanemachine closed 10 months ago

arcanemachine commented 11 months ago

Versions Used Kaffy: 0.9.4 Phoenix: 1.7.7 Elixir: 1.14.5-otp-26

What's actually happening?

When I run mix deps.compile kaffy, the following deprecation warnings appear:

  1. warning: the :phoenix compiler is no longer required in your mix.exs.

  2. warning: Phoenix.Controller.get_flash/2 is deprecated. get_flash/2 is deprecated. Use Phoenix.Flash.get(@flash, key) instead

What should happen instead?

There should be no deprecation warnings.

I believe that both deprecation warnings appeared in Phoenix v1.7.0-rc.0.

The first warning is referenced in this commit.

For the second warning, the current Phoenix changelog indicates that the deprecation warning appeared in Phoenix v1.7.0-rc.0.

I understand that this project current supports Phoenix >=v1.5.0 so removing the deprecated items probably isn't an option for now. I just wanted to put it on the record.

aesmail commented 10 months ago

Thank you @arcanemachine You're right. Kaffy currently supports the officially maintained elixir versions (>= 1.11 as of this writing) and phoenix >= 1.5. I would love to get rid of the deprecation warnings if there's a way around it.