search

aesmail / kaffy

Powerfully simple admin package for phoenix applications
https://kaffy.fly.dev/admin/
MIT License
1.3k stars 153 forks source link

Phx.1.7.10 fix #306

Closed drobban closed 2 months ago

drobban commented 5 months ago

Related to issue #305

Passes available tests and seems to spin nice locally on my machine

Bumps kaffy version; I think this might be the right move, as it might break backwards compat with older versions of Phoenix.

Changed deps versions to follow and fix the compile errors when using Kaffy with Phoenix 1.7.10 and phoenix_html 4.0

Would be awesome if more people could confirm & check this PR out.

nathany-copia commented 5 months ago

This update worked for me as well. Thanks @drobban.

drobban commented 5 months ago

This update worked for me as well. Thanks @drobban.

Thanks for testing it out!

phortx commented 4 months ago

Tested. Seems to work for me too :)

eriknaslund commented 3 months ago

Seems very similar to https://github.com/aesmail/kaffy/pull/308, right? We should probably just merge one of them.

drobban commented 2 months ago

Seems very similar to #308, right? We should probably just merge one of them.

look pretty identical to me =D

To me it doesn't matter which one gets merged if any.

I guess @aesmail has other priorities at the moment, the next best thing (until he has looked at the pr) is if people could test and run with the changes in this PR to make sure everything works as expected.

mustela commented 2 months ago

I've been testing these changes for a couple of days already and no problems for now.

vitalis commented 2 months ago

@aesmail @drobban Can this please be released? Kaffy is a really great lib and thank you for it!! Support of the latest libs will be an amazing feature :)

drobban commented 2 months ago

@aesmail super! Commit fixed to not bump kaffy version - still a bit rusty when it comes to git tooling, so just give a shout if I managed to screw something up, but it looks to be fine now (i think) :sweat_smile: .

vitalis commented 2 months ago

@aesmail Can you please review and release the update? Thank you

drobban commented 2 months ago

@aesmail Can you please review and release the update? Thank you

It will happen when he has time. While waiting, you are able to use this PR as a temporary dep in your project.

{:kaffy, github: "drobban/kaffy", ref: "66d0c7d"} or simply fork my repo/branch and use that, then you wont risk the repo simply disappearing, but at the same time, if the branch disappears its a signal to switch back to upstream :smile:

And when merged simply switch back to follow upstream again.

We cant forget that much of the opensource is peoples spare time spent making stuff that we are able to use for free. If we really need the service of getting things perfectly served as we would from a paid service... Well then "we" should consider to actually pay for it.

https://github.com/sponsors/aesmail :peace_symbol: :heart:

vitalis commented 2 months ago

Dear @drobban , I will not do it for a few basic reasons. :)

First, we are human and often forget that we are using forks, especially when they work well. :)

Second, there's a thing called collaboration in the open source community; if someone has invested time to solve an issue or improve the product, there's no reason the project maintainer can't respond with gratitude and review/merge the PR as soon as possible, instead of waiting for a comfortable moment in life. :)

Additionally, this project hasn't been updated or maintained for a very long time. Usually, in the open source community, ownership is transferred to someone eager to advance the project.

I'd rather not use it at all than resort to using a fork. This also highlights that if something major requiring immediate attention occurs (as anything can happen), it will not be addressed.

And this is exactly why developers are leaving Elixir. The community...

Strong words, I know, but this is the reality.

vitalis commented 2 months ago

@aesmail Can you please review and release the update? Thank you

It will happen when he has time. While waiting, you are able to use this PR as a temporary dep in your project.

{:kaffy, github: "drobban/kaffy", ref: "66d0c7d"} or simply fork my repo/branch and use that, then you wont risk the repo simply disappearing, but at the same time, if the branch disappears its a signal to switch back to upstream 😄

And when merged simply switch back to follow upstream again.

We cant forget that much of the opensource is peoples spare time spent making stuff that we are able to use for free. If we really need the service of getting things perfectly served as we would from a paid service... Well then "we" should consider to actually pay for it.

https://github.com/sponsors/aesmail ☮️ ❤️

Yes, almost forgot.. I'm sure you and @aesmail sponsor every open source project that you use at work and at home.. ;)

vitalis commented 2 months ago

@aesmail Can you please review and release the update? Thank you

It will happen when he has time. While waiting, you are able to use this PR as a temporary dep in your project. {:kaffy, github: "drobban/kaffy", ref: "66d0c7d"} or simply fork my repo/branch and use that, then you wont risk the repo simply disappearing, but at the same time, if the branch disappears its a signal to switch back to upstream 😄 And when merged simply switch back to follow upstream again. We cant forget that much of the opensource is peoples spare time spent making stuff that we are able to use for free. If we really need the service of getting things perfectly served as we would from a paid service... Well then "we" should consider to actually pay for it. https://github.com/sponsors/aesmail ☮️ ❤️

Yes, almost forgot.. I'm sure you and @aesmail sponsor every open source project that you use at work and at home.. ;)

I do "pay" for something that is a product and maintained: https://github.com/danschultzer

drobban commented 2 months ago

@aesmail Can you please review and release the update? Thank you

It will happen when he has time. While waiting, you are able to use this PR as a temporary dep in your project. {:kaffy, github: "drobban/kaffy", ref: "66d0c7d"} or simply fork my repo/branch and use that, then you wont risk the repo simply disappearing, but at the same time, if the branch disappears its a signal to switch back to upstream 😄 And when merged simply switch back to follow upstream again. We cant forget that much of the opensource is peoples spare time spent making stuff that we are able to use for free. If we really need the service of getting things perfectly served as we would from a paid service... Well then "we" should consider to actually pay for it. https://github.com/sponsors/aesmail ☮️ ❤️

Yes, almost forgot.. I'm sure you and @aesmail sponsor every open source project that you use at work and at home.. ;)

dude... https://c.tenor.com/-Cr1JqBDtfIAAAAC/tenor.gif Feel free to remind me if you find me trying to get VIP fast lane treatment.

Im just another dude making stuff for free as well, I have no more connection than you to this project.

drobban commented 2 months ago

Dear @drobban , I will not do it for a few basic reasons. :)

First, we are human and often forget that we are using forks, especially when they work well. :)

Second, there's a thing called collaboration in the open source community; if someone has invested time to solve an issue or improve the product, there's no reason the project maintainer can't respond with gratitude and review/merge the PR as soon as possible, instead of waiting for a comfortable moment in life. :)

Additionally, this project hasn't been updated or maintained for a very long time. Usually, in the open source community, ownership is transferred to someone eager to advance the project.

I'd rather not use it at all than resort to using a fork. This also highlights that if something major requiring immediate attention occurs (as anything can happen), it will not be addressed.

And this is exactly why developers are leaving Elixir. The community...

Strong words, I know, but this is the reality.

Having this conversation here is wildly off topic. So this will be the last message of this character I'll respond to.

  1. I dont need you to be my white knight trying to force @aesmail to merge my PR. I was the one creating the patch - If I have issues with @aesmail, then its up to me if I want to have that discussion or not.
  2. Sure, its about collaboration. Have you tested this pull request out? Have you verified and gotten any results to report back? Sure I sincerely appreciate when I receive praises from people for work I do, but I do appreciate feedback and test results more.
  3. I just came home from Lisbon & the elixir euro conference. The community seems to be running strong, so I dont know what kind of reality you live in.

If you want to continue having this discussion, we can take it on IRC in #elixir @ libera.chat

Best regards David Peace out.

vitalis commented 2 months ago

@aesmail Can you please review and release the update? Thank you

It will happen when he has time. While waiting, you are able to use this PR as a temporary dep in your project. {:kaffy, github: "drobban/kaffy", ref: "66d0c7d"} or simply fork my repo/branch and use that, then you wont risk the repo simply disappearing, but at the same time, if the branch disappears its a signal to switch back to upstream 😄 And when merged simply switch back to follow upstream again. We cant forget that much of the opensource is peoples spare time spent making stuff that we are able to use for free. If we really need the service of getting things perfectly served as we would from a paid service... Well then "we" should consider to actually pay for it. https://github.com/sponsors/aesmail ☮️ ❤️

Yes, almost forgot.. I'm sure you and @aesmail sponsor every open source project that you use at work and at home.. ;)

dude... https://c.tenor.com/-Cr1JqBDtfIAAAAC/tenor.gif Feel free to remind me if you find me trying to get VIP fast lane treatment.

Im just another dude making stuff for free as well, I have no more connection than you to this project.

So... if you not related to the project why do you write such comments? I politely asked for a simple thing.. and you just made everything so complicated.. I really don't get you "dude", I prefer m8.. more respectful ;)

ghenry commented 2 months ago

Hi all,

I also volunteer here as I use this in https://github.com/SentryPeer/SentryPeerHQ and an internal project at work. I helped review issues and PRs, so @aesmail gave me commit rights ages ago. If you use a project, see it needs help, this is one way you can help vs not sponsoring etc. You know how this works :-)

I've been busy too, so apologies for that.

Are we happy with this to merge then? There's no harm, we can revert it if not. Our users have tested and seem to be happy. Merging now.

Thanks all.

vitalis commented 2 months ago

Hi all,

I also volunteer here as I use this in https://github.com/SentryPeer/SentryPeerHQ and an internal project at work. I helped review issues and PRs, so @aesmail gave me commit rights ages ago. If you use a project, see it needs help, this is one way you can help vs not sponsoring etc. You know how this works :-)

I've been busy too, so apologies for that.

Are we happy with this to merge then? There's no harm, we can revert it if not. Our users have tested and seem to be happy. Merging now.

Thanks all.

Thank you!!!!!

vitalis commented 2 months ago

Thank you @drobban !!, I really appreciate your investment in this project

ghenry commented 2 months ago

Remember, this isn't a release yet.