aesophor / wmderland

🌳 X11 tiling window manager using space partitioning trees
https://www.reddit.com/r/unixporn/comments/fb8ve1/wmderland_104_time_to_move_on/
MIT License
409 stars 15 forks source link

[New feature] resizing tiled windows (split ratio) #47

Closed takagiy closed 4 years ago

takagiy commented 4 years ago

This request is going to add some interfaces to make it possible to resize tiled windows with keys. By this, the class Tree::Node will have new member variable ratio_ which represents how long the window is to its parent node and we will be able to resize the windows by modifying its ratio_. Concretely, this request adds following four new actions.

This request also adds some example configurations using these new actions. Please feel free to let me know if you have any questions.

Thank you!

aesophor commented 4 years ago

Thank you so much for this amazing patch... Everything is implemented so perfectly :smile_cat: :smile_cat: :smile_cat:

I only spotted one (possible) glitch. Here's the steps to reproduce:

  1. spawn two windows (horizontally)
  2. press $Mod+$Alt+0 (Now these two windows will overlap with each other)

I think perhaps we can remove bindsym $Mod+$Alt+0 resize_set_ratio 100 if it doesn't have special purposes?

Thank you again for your hard work! Love this so much...